mw/com: Add PRIVATE support for semi dynamic data types#632
Merged
Conversation
bemerybmw
force-pushed
the
brem_semi_dynamic_methods
branch
2 times, most recently
from
9c07968 to
9ee4526
Compare
bemerybmw
requested review from
LittleHuba,
castler,
crimson11,
hoe-jo and
limdor
as code owners
crimson11
requested changes
Jul 3, 2026
| } | ||
|
|
||
| private: | ||
| std::unique_ptr<typename Proxy::HandleType> handle_{nullptr}; |
Contributor
There was a problem hiding this comment.
this should be rather an std::optional ... and not a heap allocated unique_ptr ...
Adds support for dynamic types which allocate once at runtime. An additional size in bytes can be passed to a private proxy Create function which increases the amount of shared memory allocated for methods. An application can then create a data type which guarantees to not allocate more than the provided value. An example test application is created mw/com/test/methods/semi_dynamic_methods. This should only be used in the context of SWP-269486. Any other usage of this is a violation of our AOU: NoApisFromImplementationNamespace
bemerybmw
force-pushed
the
brem_semi_dynamic_methods
branch
from
9ee4526 to
fea66e6
Compare
crimson11
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for dynamic types which allocate once at runtime. An
additional size in bytes can be passed to a private proxy Create
function which increases the amount of shared memory allocated for
methods. An application can then create a data type which guarantees to
not allocate more than the provided value.
An example test application is created
mw/com/test/methods/semi_dynamic_methods.
This should only be used in the context of SWP-269486. Any other usage
of this is a violation of our AOU: NoApisFromImplementationNamespace